search

datacamp / shellwhat

https://shellwhat.readthedocs.io
GNU Affero General Public License v3.0
2 stars 8 forks source link

Compare file containing learner output with reference file. #23

Closed gvwilson closed 6 years ago

gvwilson commented 6 years ago

Moved into a branch in this repo - was originally PR'd from a fork.

machow commented 6 years ago

literal string interpolation syntax was introduced in python 3.6, but DataCamp currently uses python 3.5 :(.

gvwilson commented 6 years ago

I'll amend. Thx, G

On Fri, Sep 8, 2017 at 9:38 AM, Michael Chow notifications@github.com wrote:

String literal interpolation syntax was introduced in python 3.6, but DataCamp currently uses python 3.5 :(.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/datacamp/shellwhat/pull/23#issuecomment-328105641, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3ozoCGEvXMzjflYMbur1i4O_tnHHCKks5sgUNQgaJpZM4PO2cX .

filipsch commented 6 years ago

@gvwilson is this still happening/necessary?

gvwilson commented 6 years ago

Yes, or something like it - we need to compare their shell scripts with the ones we asked them to write. Should use fuzzy matching (ignore extra whitespace etc.)

filipsch commented 6 years ago

@gvwilson will you wrap up on this or do you expect me to take over?

gvwilson commented 6 years ago

I'm happy to bring it up to date when the new SCT API is in place - thanks.

gvwilson commented 6 years ago

Could someone please merge or close.