Codecov Report

Merging #45 into master will decrease coverage by 4.79%. The diff coverage is 88.75%.

@@            Coverage Diff            @@
##           master      #45     +/-   ##
=========================================
- Coverage   96.46%   91.66%   -4.8%     
=========================================
  Files           7        8      +1     
  Lines         113      144     +31     
=========================================
+ Hits          109      132     +23     
- Misses          4       12      +8

Impacted Files	Coverage Δ
shellwhat/__init__.py	`100% <100%> (ø)`	:arrow_up:
shellwhat/State.py	`100% <100%> (ø)`	:arrow_up:
shellwhat/sct_syntax.py	`100% <100%> (ø)`	:arrow_up:
shellwhat/reporter.py	`100% <100%> (ø)`
shellwhat/checks/__init__.py	`100% <100%> (ø)`	:arrow_up:
shellwhat/test_exercise.py	`100% <100%> (ø)`	:arrow_up:
shellwhat/parsers.py	`78.43% <78.94%> (-7.29%)`	:arrow_down:
shellwhat/checks/has_funcs.py	`98.11% <96.29%> (ø)`
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ee2f875...f9945db. Read the comment docs.

machow commented 5 years ago

@hermansje I'm not sure how to review this--black code formatting has changed most files, so it's hard to tell what changes are new functionality, and which are stylistic. Are there specific parts I should look at?

machow commented 5 years ago

RE the modified oil shell code--I'm not sure how much I can help, but happy to try installing / using! If you want to pair to go over anything, feel free to put something on my calendar

hermansje commented 5 years ago

@machow this should make it easier:

datacamp / shellwhat

Update protowhat and Osh parsing #45

Codecov Report