filipsch commented 5 years ago

This is needed to make the SCTs from @sumedh10's Transact SQL course work.

Currently, this branch is baked into the course image of the course corresponding to the sp-sample-scts branch, so should no longer be blocking.

However, this still needs more work in the form of unit tests (which needs more CI work, because we currently only set up a sqlite database to test against).

filipsch commented 5 years ago

@hermansje I'm not comfortable slotting this in if it is not properly tested (probably against a docker running mssql).

codecov[bot] commented 4 years ago

Codecov Report

Merging #130 into master will decrease coverage by 0.86%. The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
- Coverage   97.64%   96.77%   -0.87%     
==========================================
  Files           6        6              
  Lines         212      217       +5     
==========================================
+ Hits          207      210       +3     
- Misses          5        7       +2

Impacted Files	Coverage Δ
sqlwhat/checks/check_funcs.py	`96.98% <77.77%> (-1.15%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 400d5ad...31ab477. Read the comment docs.

filipsch commented 4 years ago

Closing this as it clutters my /pulls overview on GitHub. Feel free to reopen a PR with the branch if you think these changes still make sense :)

datacamp / sqlwhat

[WIP][LE-1044] update check_query to deal with mssql #130

Codecov Report