datacamp / sqlwhat

https://sqlwhat.readthedocs.io
GNU Affero General Public License v3.0
3 stars 8 forks source link

function names should reflect what is happening to state #18

Closed machow closed 7 years ago

machow commented 7 years ago

Currently the three functions

all begin with check, but only the last two change state (by fetching a new AST node). It seems like we should change check_result, whose behavior will change depending on the state (e.g. called after check_statement('select', ...)) to test or test_result.