datacamp / sqlwhat

https://sqlwhat.readthedocs.io
GNU Affero General Public License v3.0
3 stars 8 forks source link

Move student query errors to state, rather than reporter #66

Closed machow closed 7 years ago

machow commented 7 years ago

closing for now with remarks from PR, but we can reopen later if necessary!

Right now, at least for sqlwhat and pythonwhat, the reporter holds a lot of the logic related to whether an overall SCT passes or fails, so putting the error on it doesn't seem too crazy. Especially since it's an error message, and messages are the reporters jam.