datacamp / testwhat

Write Submission Correctness Tests for R exercises
https://datacamp.github.io/testwhat
GNU Affero General Public License v3.0
33 stars 25 forks source link

Nested check function #230

Closed hermansje closed 5 years ago

hermansje commented 5 years ago

@richierocks I used your work to make all the old and new tests work by using your dot detection and replacement code. The new test "check_function works with more deeply nested code" was still breaking, which turned out to be because of the support for qualified access elsewhere, so I added an extra test case and modified standardize_call.

All tests are working now.

codecov[bot] commented 5 years ago

Codecov Report

Merging #230 into master will increase coverage by 0.04%. The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #230      +/-   ##
==========================================
+ Coverage   92.11%   92.15%   +0.04%     
==========================================
  Files          47       47              
  Lines        2649     2651       +2     
==========================================
+ Hits         2440     2443       +3     
+ Misses        209      208       -1
Impacted Files Coverage Δ
R/utils-function.R 89.28% <83.33%> (+1.1%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fe844ff...22ea492. Read the comment docs.