datacarpentry / OpenRefine-ecology-lesson

Data Cleaning with OpenRefine for Ecologists
https://datacarpentry.org/OpenRefine-ecology-lesson/
Other
25 stars 112 forks source link

URLs seem incorrect in setup.md for OpenRefine #292

Closed debpaul closed 1 year ago

debpaul commented 1 year ago

Question: How are you generating these links to sections of the markdown page? In looking at them I see links like this

Issue: then I see some links to different sections of the page that have the same URL, like this Section URL Data https://datacarpentry.org/OpenRefine-ecology-lesson/#prereq1 Software https://datacarpentry.org/OpenRefine-ecology-lesson/#prereq2 For Instructors https://datacarpentry.org/OpenRefine-ecology-lesson/#prereq2 Getting Started https://datacarpentry.org/OpenRefine-ecology-lesson/#prereq1

I would expect to see

Data https://datacarpentry.org/OpenRefine-ecology-lesson/#data Software https://datacarpentry.org/OpenRefine-ecology-lesson/#software For Instructors https://datacarpentry.org/OpenRefine-ecology-lesson/#for-instructors Getting Started https://datacarpentry.org/OpenRefine-ecology-lesson/#getting-started

Am I missing something? I find it odd that different sections of the page have the same URL+anchortag Thanks for help.

bencomp commented 1 year ago

That is a good observation, @debpaul. It appears this may be a bug. I will add an issue to the Workbench.

debpaul commented 1 year ago

That is a good observation, @debpaul. It appears this may be a bug. I will add an issue to the Workbench.

Thanks @bencomp I'd have done a pull request, but didn't have time to go and do that... so you got this ticket instead. You're suggesting too, that if I find other issues, there's a specific Workbench repo where I need to submit these tickets instead? Please point me to it? Thanks!

bencomp commented 1 year ago

The Workbench consists of several repositories; I think it should go in https://github.com/carpentries/sandpaper/issues. I see the same issue happen in the lesson on OpenRefine for Social Sciences, so this is related to the infrastructure, not this lesson.

debpaul commented 1 year ago

The Workbench consists of several repositories; I think it should go in https://github.com/carpentries/sandpaper/issues. I see the same issue happen in the lesson on OpenRefine for Social Sciences, so this is related to the infrastructure, not this lesson.

Yes, that's what I wondered, they looked auto-generated. Thanks for pointing me to where they are, in case I note something else.

bencomp commented 1 year ago

I opened https://github.com/carpentries/sandpaper/issues/454 for this.

bencomp commented 1 year ago

This has been fixed thanks to carpentries/sandpaper#467.