search

datacarpentry / OpenRefine-ecology-lesson

Data Cleaning with OpenRefine for Ecologists
https://datacarpentry.org/OpenRefine-ecology-lesson/
Other
25 stars 112 forks source link

Fix 'Text filters' section #301

Open marijane opened 1 year ago

marijane commented 1 year ago

The sentence introducing this section ended with the clause "and reinstate the text facet on the scientificName column", but the exercise that follows expects this facet to be closed. I removed this part of the sentence to make the exercise flow more logically from the preceding text.

github-actions[bot] commented 1 year ago

Thank you!

Thank you for your pull request :smiley:

:robot: This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

Rendered Changes

:mag: Inspect the changes: https://github.com/datacarpentry/OpenRefine-ecology-lesson/compare/md-outputs..md-outputs-PR-301

The following changes were observed in the rendered markdown documents:

 05-filter-exclude-sort.md | 2 +-
 md5sum.txt                | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
What does this mean? If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

:stopwatch: Updated at 2023-09-22 07:05:15 +0000

bencomp commented 1 year ago

Thanks for this, @marijane. I agree that removing this part of the sentence improves the text flow. But then the screen shot already includes the text facet too. Could you move it inside the solution of the exercise?