search

datacarpentry / R-ecology-lesson

Data Analysis and Visualization in R for Ecologists
https://datacarpentry.org/R-ecology-lesson/
Other
314 stars 508 forks source link

Adding clarifying language in Converting Factors section of 02-starti… #858

Closed alevan2p closed 4 months ago

alevan2p commented 1 year ago

…ng-with-data.Rmd

When I first looked through this lesson, I was a bit confused by the difference between subsetting with a factor (such as in this example) and a standard numeric vector.

Since in this example we are not selecting a subset of elements based on their position in a vector or dataframe (such as in the lesson's previous examples), I thought it might be worth including this additional text.

Please delete this line and the text below before submitting your contribution.

Thanks for contributing! If this contribution is for instructor training, please send an email to checkout@carpentries.org with a link to this contribution so we can record your progress. You’ve completed your contribution step for instructor checkout just by submitting this contribution.

Please keep in mind that lesson maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at team@carpentries.org.

github-actions[bot] commented 1 year ago

:ok: Pre-flight checks passed :smiley:

This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits.

It should be safe to Approve and Run the workflows that need maintainer approval.

jamesmbaazam commented 1 year ago

Thank you for your input @alevan2p. I agree that it adds more clarity.

tobyhodges commented 4 months ago

Thank you for contributing this suggestion, @alevan2p. This lesson underwent a major reorganisation when https://github.com/datacarpentry/R-ecology-lesson/pull/887 was merged, and the episode that you suggested this Instructor Note be added to no longer exists. Unfortunately, that means I am going to have to close this pull request.

If you have time, please review the content in the Building with Vectors section. If you think the explanation there could be improved, and would be willing to update your fork and open a new pull request suggesting improvements, I or one of the Maintainers will be delighted to review and merge it.