datacarpentry / R-ecology-lesson

Data Analysis and Visualization in R for Ecologists
https://datacarpentry.org/R-ecology-lesson/
Other
311 stars 509 forks source link

Improve keyboard button visibility in before-we-start #882

Closed ragamouf closed 8 months ago

ragamouf commented 10 months ago

Currently, the keyboard tags on the Ctrl key, Enter key, Cmd key all look black, or extremely dark grey. The text is also black. I don't think this is on purpose, and looking in the code there are backticks "`" which enclose the keyboard button text. Removing these backticks will hopefully allow the text to appear white, and visible on the screen.

The screenshot below shows what I see on my google chrome browser on a mac. Screenshot 2023-11-22 at 12 37 01 pm

I checked the code below and noticed that there were no backticks around the "F1" button. Screenshot 2023-12-05 at 4 53 37 pm

github-actions[bot] commented 10 months ago

:ok: Pre-flight checks passed :smiley:

This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits.

It should be safe to Approve and Run the workflows that need maintainer approval.