Closed bencomp closed 1 year ago
Thank you for your pull request :smiley:
:robot: This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.
If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
:mag: Inspect the changes: https://github.com/datacarpentry/openrefine-socialsci/compare/md-outputs..md-outputs-PR-170
The following changes were observed in the rendered markdown documents:
01-introduction.md | 12 ------------
07-resources.md | 15 ++++++++++++++-
index.md | 12 ++++++++++++
md5sum.txt | 6 +++---
4 files changed, 29 insertions(+), 16 deletions(-)
:stopwatch: Updated at 2023-06-26 21:25:38 +0000
I think moving the "getting help" section makes sense, although the relevant learning objective should also be moved from Episode 1 to the later episode.
Adding overall objectives to the main lesson page also fits best practice and seems good to me.
Thanks for checking, @ndporter! Indeed the objective should have moved along with the contents.
Although if I add it to Other Resources, these are its LOs:
I don't think we need the more or less the same objective three times. (I don't think we should have this as an episode at all, but that is still waiting for CAC advice in #122 :)) I will leave out the "Identify" LO.
The changes to LOs look good and I think this is ready to merge. We'll bring #122 up with the CAC next meeting.
This fixes #38. It also relates to #122.
Overview:
I don't think I wrote new learning objectives, but perhaps the @datacarpentry/curriculum-advisors-social-science would like to check?