search

datacarpentry / organization-genomics

Project Organization and Management for Genomics
https://datacarpentry.org/organization-genomics
Other
23 stars 76 forks source link

Fix contributing links #155

Closed JCSzamosi closed 1 year ago

JCSzamosi commented 1 year ago

Addressing the broken links raised by @tobyhodges in #154.

This also makes the change to the "issues" list discussed in that same thread. I'm requesting @zkamvar review it before I make a similar PR to the template repo so that I only have to make changes in one place.

fixes #154

github-actions[bot] commented 1 year ago

Thank you!

Thank you for your pull request :smiley:

:robot: This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

Rendered Changes

:mag: Inspect the changes: https://github.com/datacarpentry/organization-genomics/compare/md-outputs..md-outputs-PR-155

The following changes were observed in the rendered markdown documents:

What does this mean? If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

:stopwatch: Updated at 2023-06-05 16:56:16 +0000

JCSzamosi commented 1 year ago

If @zkamvar approves the "issues list" change and can point me to a list of repos that have been converted to Workbench, I am happy to create similar PRs for those repos in addition to the template repo.

zkamvar commented 1 year ago

HI @JCSzamosi, thank you so much! I agree that the "issues list" phrasing is a very sensible change.

You can find a list of repositories that have been transitioned in https://carpentries.github.io/workbench/transition-schedule.html

They are also listed as issue titles in the lesson transition repository, so you can use the GitHub API to retrieve a machine-readable list:

GET /repos/carpentries/lesson-transition/issues?status=closed&label=lesson
JCSzamosi commented 1 year ago

Thank you @zkamvar!

I know best practice says PRs should not be proposed and approved by the same maintainer, so I'm going to give it a couple days for another @datacarpentry/organization-genomics-maintainers maintainer to merge this.

In the mean time, I will create PRs for the template repo and existing, transitioned repos

hidyverse commented 1 year ago

Thanks for being on top of this @JCSzamosi

JCSzamosi commented 1 year ago

Since no one has objected in the past several days, I'm going to merge this now.