search

datacarpentry / organization-genomics

Project Organization and Management for Genomics
https://datacarpentry.org/organization-genomics
Other
23 stars 76 forks source link

Add a picture from the Tenaillon et al. paper demonstrating how to find SRA accessions #98

Closed taylorreiter closed 5 years ago

taylorreiter commented 5 years ago

This pull request addresses #82. Thank you @ErinBecker for securing the license!

hoytpr commented 5 years ago

Hi @taylorreiter and thanks very much for the PR. We appreciate your efforts (really!) but because we don't want to add too much to any lesson (most don't finish anyway) I'd suggest limiting this to one figure. Your figures were really big, and that might affect the lesson layout, or maybe slow down the page loading. We should resize those images.

In my opinion, if we can just put a direct link to the manuscript e.g. https://www.ncbi.nlm.nih.gov/pmc/articles/PMC4988878/, it would be sufficient for the title and authors. The direct link to the Nature site might be paywalled, but the PMC should be free... I think. So the purpose of this suggestion is to help learners understand that these data can be located in the manuscripts, but you might have to look for them... correct? That's a really good point and to keep it short I'd suggest something like:

See the figure below for where the data was presented in the original paper. The authors provided a "PRJNA" accession which is an NCBI BioProject identifier. Be aware that these data can show up in different places depending on the journal, and in this example it was located after the reference section.

What do you think of that? Thanks again! Peter

raynamharris commented 5 years ago

I like the first image a lot. I especially like seeing the title and the list of authors.

I think the second image might be more useful if it were inserted a text with clickable hyperlinks. It could be formatted as a callout or a discussion or as plain text.

hoytpr commented 5 years ago

With @taylorreiter approval, and @ErinBecker merging the large PR that includes these images and suggestions from @raynamharris , we can close #98