datacarpentry / organization-geospatial

Introduction to Geospatial Concepts
https://www.datacarpentry.org/organization-geospatial/
Other
36 stars 31 forks source link

Adding slides for intro lessons #43

Closed jebyrnes closed 1 year ago

jebyrnes commented 5 years ago

This PR serves the need for some RMarkdown slides - see geospatial_intro_slides.Rmd. I have to admit, as this is my first time making such a large contribution, rather than just a tweak, I'm a hair unclear about how to fold this into the full workflow. However, if these slides were here, and linked to in the overview, they might provide an easy resource for intructors in this first lesson - there's no live coding, so having a set of slides that matches the lessons might be easy.

Now, this might not merge seamlessly as

  1. I am not familiar with the make process, and haven't been able to use make with these slides successfully.
  2. I chose a default RMarkdown slides template - but something else might be better.
  3. While I copy-pasted code blocks, there might be a more elegant way of importing from the lessons. I tried to figure out how to do so, but my google-fu failed me, unless we want to split out the blocks into their own .R files, and then use read_chunks() on them to have shared blocks across files. That seemed like a more major refactoring - which I'm happy to do if the admins want it. But I figured I'd stay away from that for the moment. Happy to hear thoughts, though.

So, take a look, knowing that some editing is definitely necessary to make it part of the whole workflow. I also didn't link it back to the index, as I figured that should wait until it was completely approved (if at all).

Let me know - but this could go a long way towards many instructors not reinventing the slide-wheel on this one.

jsta commented 5 years ago

I like this idea. I agree that importing would be preferable over copy-pasting. That way changes would propagated from the lessons to the slides and vice-versa. Maybe we could try concatenating the Rmds like at: https://stackoverflow.com/a/25825910/3362993

jebyrnes commented 5 years ago

I like that idea - can you give me a reprex of how that would work for both slides and documents? Or - we could just move the code to .R files and read in the chunks to work from in common between files. Might not be a bad idea.

zkamvar commented 1 year ago

Thank you for your contribution. This lesson has migrated to use The Carpentries Workbench, but unfortunately, due to various factors, the Maintainers of this lesson were unable to address this pull request before the transition. Because of this, we had to close your pull request.

Please note that this does not mean that your contribution was not valued. There are many reasons why a pull request is not merged. It's important to remember that the Maintainers are first and foremost people---people who maintain this lesson on a voluntary basis. Sometimes pull requests become stale because other responsibilities take precedence. Thank you for taking the time to open the pull request in the first place.

If you wish to contribute again, you will need to delete and re-fork your repository.

How to contribute

If you wish to contribute, you will need to use the following steps to delete, re-fork, and re-create your pull request (aka the burn it all down strategy):

:video_camera: How to update (delete) your fork https://carpentries.github.io/workbench/faq.html#update-fork-from-styles

  1. Save your edits on locally or in a scratch space.
  2. Delete your fork
  3. Create a new fork or use the "edit" button on the page you wish to edit.
  4. Apply your changes (NOTE The Workbench uses a different syntax. Here is a Transition Guide from Styles to Workbench for your reference).

Questions

If you have any questions or would like assistance, please contact @core-team-curriculum (email: curriculum@carpentries.org) or you can respond to this message.