search

datacarpentry / python-ecology-lesson

Data Analysis and Visualization in Python for Ecologists
https://datacarpentry.org/python-ecology-lesson
Other
162 stars 308 forks source link

Use GitHub link instead of "DownGit" service #372

Closed remram44 closed 5 years ago

remram44 commented 5 years ago

I don't understand why this was done in #231. GitHub has built-in download links, I was surprised to see this fancy JavaScript service being used for this.

This seems like a 404 waiting to happen, and can't be good for accessibility.

This is what DownGit itself uses anyway:

var downloadUrl = "https://github.com/"+repoInfo.author+"/"+
    repoInfo.repository+"/archive/"+repoInfo.branch+".zip";
remram44 commented 5 years ago

The set of files appears to be different in either case, the ZIP has a bunch more files but is missing speciesSubset.csv and bouldercreek_09_2013.txt

wrightaprilm commented 5 years ago

I'm hoping to get this fixed up for the new lesson release. It's a known issue that I've kind of punted on. All the lessons are meant to be using Figshare for data hosting, rather than storing in the repo. But maintainers don't have write access to that, so I'm waiting on someone in leadership to handle that.

I'm going to merge this for the time being, though, so that all the files are in sync. Thanks for noticing and sending us a PR, Remi.