datacarpentry / python-ecology-lesson

Data Analysis and Visualization in Python for Ecologists
https://datacarpentry.org/python-ecology-lesson
Other
160 stars 310 forks source link

Assorted minor fixes and improvements #435

Closed katrinleinweber closed 4 years ago

katrinleinweber commented 4 years ago

As I'm preparing a workshop with this lesson, I'll collect some typo fixes, formatting improvements, and IMHO better wordings here. Please feel free to review or cherry-pick already.

maxim-belkin commented 4 years ago

Thanks, Katrin. Although I prefer small PRs (one per file), all changes you make here are straightforward and good so I approve. Let me know if I can merge it now or if you'd like to spend more time looking at the lesson.

katrinleinweber commented 4 years ago

Thanks! The workshop is in mid-February ;-)

I know it's not optimal, but I need to reduce distractions for myself while preparing the material. Maintaining different branches per improvement type I find while reading through everything, keeping a few separate content changes we want to have in the lesson rebased on them all, and firing off a handful of PRs at the same time shortly before or after the workshop is not optimal either :-/

Even while I was a maintainer myself, I couldn't figure out a better workflow that ensured both sending improvement suggestions and focussing on learning the material. I'm all ears for suggestions :-)

maxim-belkin commented 4 years ago

Alright then. I'll wait till you say it is good to re-review & merge.

maxim-belkin commented 4 years ago

a gentle ping, Katrin, just to make sure this PR is on your radar.

katrinleinweber commented 4 years ago

On it, until "mid-February" ;-)

katrinleinweber commented 4 years ago

I need to stop this piecemeal, in order to get down with the lesson content. Future updates will be in smaller PRs ;-)

maxim-belkin commented 4 years ago

.--. .. -. --. / ---... -.--.-

katrinleinweber commented 4 years ago

The workshop was last week, so I'm finished here ;-)

maxim-belkin commented 4 years ago

Thank you, Katrin! I believe this is yours ~>🥇

katrinleinweber commented 4 years ago

You're welcome & thanks for merging :-)