datacarpentry / python-ecology-lesson

Data Analysis and Visualization in Python for Ecologists
https://datacarpentry.org/python-ecology-lesson
Other
160 stars 310 forks source link

Broken links in contributing.md #450

Closed nettic closed 4 years ago

nettic commented 4 years ago

The contributing.md file has at least 3 broken links. Link to file: https://github.com/datacarpentry/python-ecology-lesson/blob/gh-pages/CONTRIBUTING.md

The 3 links are in the section "What to contribute". "or you may also look at the issues for Data Carpentry, Software Carpentry, and Library Carpentry projects." (broken links are bold).

Wrong links: Data Carpentry: https://github.com/issues?q=user%3Adatacarpentry Software Carpentry: https://github.com/issues?q=user%3Aswcarpentry Library Carpentry: https://github.com/issues?q=user%3Alibrarycarpentry

Corrected links: Data Carpentry: https://github.com/search?q=user%3Adatacarpentry Software Carpentry: https://github.com/search?q=user%3Asoftwarecarpentry Library Carpentry: https://github.com/search?q=user%3Alibrarycarpentry

Cheers Sebastian

maxim-belkin commented 4 years ago

Hi Sebastian,

I'm not positive the links you list above are broken - they bring me to proper locations when I click on them. Why do you think they're broken?

Maxim

nettic commented 4 years ago

Unfortunately, still for me they are broken. See screenshot in a pdf: Page not found GitHub.pdf

maxim-belkin commented 4 years ago

Does https://github.com/issues work for you?

nettic commented 4 years ago

Yes. It shows me my issues (this issue).

maxim-belkin commented 4 years ago

Could you please try replacing the text in the search box with user:datacarpentry and report the full URL you end up at?

nettic commented 4 years ago

This is my URL: https://github.com/issues?utf8=✓&q=user%3Adatacarpentry

nettic commented 4 years ago

The following works fine, too: https://github.com/issues?q=user%3Adatacarpentry

maxim-belkin commented 4 years ago

This is my URL: https://github.com/issues?utf8=✓&q=user%3Adatacarpentry

Good, this is the URL I end up on too.

So, I'm a bit confused. Do links work for you or not? Previously you said:

Wrong links: Data Carpentry: https://github.com/issues?q=user%3Adatacarpentry

And now:

The following works fine, too: https://github.com/issues?q=user%3Adatacarpentry

These two links seem identical to me.

nettic commented 4 years ago

Now, it is working for me, too......:-0 I am confused. Sorry!

nettic commented 4 years ago

I realized, that this error occurs, when I am in a private tab and click the links with opening in a second private tab!

maxim-belkin commented 4 years ago

I realized, that this error occurs, when I am in a private tab and click the links with opening in a second private tab!

Ah, I see! Yes, one has to be logged in to GitHub to use https://github.com/issues.

Consider raising this issue in the carpentries/styles repository -- this is where all The Carpentries lessons get CONTRIBUTING.md from. Perhaps, we should add a sentence or two explaining that one has to be logged in (to GitHub) and not in Private browsing mode to use these links.

Thank you for the report anyway! Things like these links can change in the future so it's always a good idea to make sure that they work.