datacarpentry / python-ecology-lesson

Data Analysis and Visualization in Python for Ecologists
https://datacarpentry.org/python-ecology-lesson
Other
160 stars 310 forks source link

Improve pandas code and formatting #468

Closed deppen8 closed 1 year ago

deppen8 commented 4 years ago

Please delete this line and the text below before submitting your contribution.


Thanks for contributing! If this contribution is for instructor training, please send an email to checkout@carpentries.org with a link to this contribution so we can record your progress. You’ve completed your contribution step for instructor checkout just by submitting this contribution.

Please keep in mind that lesson maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at team@carpentries.org.


maxim-belkin commented 4 years ago

Thank you, Jacob! Great work! I like the changes you suggest. I'm not 100% sure about the proper formatting for pandas. When we use back ticks we usually talk about code or something we type. Here, pandas is neither but a package name. How about we keep pandas "as was" for now and discuss this change in a separate PR (if you think we should do something to its style)?

tobyhodges commented 1 year ago

See my comment on #467, about pandas vs pandas. As I said there, if you would like to address Maxim's comments here, and adjust the PR to style "pandas" according to this principle, please go ahead and do so, @deppen8. (Note that you will first need to resolve the conflicts that have been introduced.) I will circle back to this one in a few weeks and make the necessary changes before merging otherwise.

tobyhodges commented 1 year ago

Superseded by #541