search

datacarpentry / python-ecology-lesson

Data Analysis and Visualization in Python for Ecologists
https://datacarpentry.org/python-ecology-lesson
Other
162 stars 307 forks source link

PR to address issue #471 #477

Closed nels closed 1 year ago

nels commented 3 years ago

Changes folder in the introductory suggested project layout from scripts to code

Referenced in issue #471, the Before we start episode 0 suggests keeping Python code in a scripts folder. Unfortunately, Anaconda has a built-in scripts module that will shadow the student's scripts folder and make

import scripts.example

fail.

The issue suggests adding an __init__.py to scripts. That adds unnecessary complexity to the introductory material and this PR proposes renaming the folder.

maxim-belkin commented 3 years ago

Thanks, @nels. This seems like a reasonable solution.

Do you agree with this fix, @itcarroll?

itcarroll commented 3 years ago

I defer to your better judgement!

tobyhodges commented 1 year ago

Returning to this 2.5 years later, in preparation for transition to the new lesson infrastructure, and it seems like this one is ready to merge. Thank you for contributing the fix, @nels, and I'm sorry it has taken such a long time to get it incorporated into the lesson.