search

datacarpentry / python-ecology-lesson

Data Analysis and Visualization in Python for Ecologists
https://datacarpentry.org/python-ecology-lesson
Other
160 stars 307 forks source link

fixes a reference to an outdated error type #571

Closed Simon-Stone closed 1 year ago

Simon-Stone commented 1 year ago

Fixes #549 by updating the reference to the error in the instructional text. To avoid confusion, the deprecated behavior (raising a ValueError) is also mentioned.

This is a contribution as part of my instructor checkout.

github-actions[bot] commented 1 year ago

Thank you!

Thank you for your pull request :smiley:

:robot: This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

Rendered Changes

:mag: Inspect the changes: https://github.com/datacarpentry/python-ecology-lesson/compare/md-outputs..md-outputs-PR-571

The following changes were observed in the rendered markdown documents:

 04-data-types-and-format.md | 4 ++--
 md5sum.txt                  | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
What does this mean? If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

:stopwatch: Updated at 2023-06-05 21:13:38 +0000

btovar commented 1 year ago

@Simon-Stone Thanks for your contribution! Your commit include changes unrelated to the bug fix, would you know how to clean up these changes and only submit the relevant change? If not, that's something I can do for you.

Simon-Stone commented 1 year ago

Your commit include changes unrelated to the bug fix, would you know how to clean up these changes and only submit the relevant change? If not, that's something I can do for you.

It looks like those are some trailing whitespaces that my IDE cleaned up automatically. Do you want me to add those back in and push another commit? Or is there a better way to fix that?

btovar commented 1 year ago

@Simon-Stone Yes, that sounds the easiest. I can then squash the pr into a single commit when merging.

Simon-Stone commented 1 year ago

@Simon-Stone Yes, that sounds the easiest. I can then squash the pr into a single commit when merging.

I hope this fixes it. Let me know if it needs any further changes!

btovar commented 1 year ago

@Simon-Stone Looks good, thanks again!