search

datacarpentry / r-intro-geospatial

Introduction to R for Geospatial Data
https://datacarpentry.org/r-intro-geospatial/
Other
47 stars 71 forks source link

Lines 123-128 #114

Closed KoontzE closed 2 years ago

KoontzE commented 2 years ago

Prior to these lines, the learner has not been taught about the shell environment or completed the shell lessons. The comparison between R and the shell environment is lost on the learner, because they don't have any prior experience (at least, within the lesson) or knowledge of shell environments. I think it would make this section less confusing to remove the shell environment language OR include a brief definition of what that means in order to provide some context, IF keeping the 'shell' language in this section is necessary.

(Note: this proposed change is written in partial fulfillment of my Carpentries instructor course checkout process)- Erika Koontz

jsta commented 2 years ago

Looks good to me

jsta commented 2 years ago

@datacarpentry/core-team I would love to merge this PR but I seem to have lost write access here.

fmichonneau commented 2 years ago

@jsta I added you to the GitHub maintainer's team. Please let me know if you still have an issue merging this PR. Thanks!