datacarpentry / r-intro-geospatial

Introduction to R for Geospatial Data
https://datacarpentry.org/r-intro-geospatial/
Other
47 stars 71 forks source link

Update 01-rstudio-intro.Rmd #132

Closed alevan2p closed 1 year ago

alevan2p commented 1 year ago

Changed some text so it referenced "DuckDuckGo" instead of "Google". Also expanded the sentence a bit more to include the term "web search engine" (line 224).

My rationale was that if we are going to highlight a specific search engine, it shouldn't be Google.

mikemahoney218 commented 1 year ago

Hi @alevan2p ! Appreciate the PR.

How would you feel about changing this to just read in a search engine, rather than mentioning any specific product?

alevan2p commented 1 year ago

"in a search engine" also sounds good, I would support that.

Thanks for everything you do!

github-actions[bot] commented 1 year ago

Thank you!

Thank you for your pull request :smiley:

:robot: This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

Rendered Changes

:mag: Inspect the changes: https://github.com/datacarpentry/r-intro-geospatial/compare/md-outputs..md-outputs-PR-132

The following changes were observed in the rendered markdown documents:

 01-rstudio-intro.md | 8 ++++----
 md5sum.txt          | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)
What does this mean? If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

:stopwatch: Updated at 2023-05-10 17:14:21 +0000

mikemahoney218 commented 1 year ago

Great! I'll merge once CI passes. Thanks for the PR :smile: