datacarpentry / r-intro-geospatial

Introduction to R for Geospatial Data
https://datacarpentry.org/r-intro-geospatial/
Other
47 stars 71 forks source link

Start to remove stringsAsFactors references #145

Closed mikemahoney218 closed 9 months ago

mikemahoney218 commented 9 months ago

If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number. This PR addresses #119 (it does not close it)

Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes. This PR does two main things:

  1. Updates Episode 3 to remove references to stringsAsFactors, and to update examples and text to match modern R versions.
  2. Updates Episode 4 to remove stringsAsFactors = FALSE where it no longer changes how the code works.

I also removed two stringsAsFactors calls from renv/activate.R which shouldn't change execution at all.

I left in the stringsAsFactors = TRUE seen in Episode 4, though I'm not confident it does anything, as well as the discussion of factors at the end of episode 4. I think there's probably a larger discussion to be had about if that section is serving our needs with R 4.3+, but I want to check and see if factors are used later in this workshop before I propose cutting it out.

If any relevant discussions have taken place elsewhere, please provide links to these.

For more guidance on how to contribute changes to a Carpentries project, please review [the Contributing Guide](CONTRIBUTING.md) and [Code of Conduct](https://docs.carpentries.org/topic_folders/policies/code-of-conduct.html). Please keep in mind that lesson Maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at team@carpentries.org.
github-actions[bot] commented 9 months ago

Thank you!

Thank you for your pull request :smiley:

:robot: This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

Rendered Changes

:mag: Inspect the changes: https://github.com/datacarpentry/r-intro-geospatial/compare/md-outputs..md-outputs-PR-145

The following changes were observed in the rendered markdown documents:

 03-data-structures-part1.md | 112 ++++++++++++++++++++++++++++++--------------
 04-data-structures-part2.md |   8 ++--
 md5sum.txt                  |   4 +-
 3 files changed, 83 insertions(+), 41 deletions(-)
What does this mean? If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

:stopwatch: Updated at 2023-09-20 19:15:27 +0000

likeajumprope commented 9 months ago

This sounds plausible to me. If @albhasan agrees I think we could merge this.

albhasan commented 9 months ago

This sounds plausible to me. If @albhasan agrees I think we could merge this.

I agree!