Closed mikemahoney218 closed 9 months ago
Thank you for your pull request :smiley:
:robot: This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.
If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
:mag: Inspect the changes: https://github.com/datacarpentry/r-intro-geospatial/compare/md-outputs..md-outputs-PR-145
The following changes were observed in the rendered markdown documents:
03-data-structures-part1.md | 112 ++++++++++++++++++++++++++++++--------------
04-data-structures-part2.md | 8 ++--
md5sum.txt | 4 +-
3 files changed, 83 insertions(+), 41 deletions(-)
:stopwatch: Updated at 2023-09-20 19:15:27 +0000
This sounds plausible to me. If @albhasan agrees I think we could merge this.
This sounds plausible to me. If @albhasan agrees I think we could merge this.
I agree!
If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number. This PR addresses #119 (it does not close it)
Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes. This PR does two main things:
stringsAsFactors = FALSE
where it no longer changes how the code works.I also removed two
stringsAsFactors
calls fromrenv/activate.R
which shouldn't change execution at all.I left in the
stringsAsFactors = TRUE
seen in Episode 4, though I'm not confident it does anything, as well as the discussion of factors at the end of episode 4. I think there's probably a larger discussion to be had about if that section is serving our needs with R 4.3+, but I want to check and see if factors are used later in this workshop before I propose cutting it out.If any relevant discussions have taken place elsewhere, please provide links to these.