search

datacarpentry / r-raster-vector-geospatial

Introduction to Geospatial Raster and Vector Data with R
https://datacarpentry.org/r-raster-vector-geospatial
Other
113 stars 110 forks source link

issue with NEON AOP LiDAR sensor not being found #125

Closed PunamA closed 6 years ago

PunamA commented 6 years ago

Hi, I was going through the intro to raster in R lesson (http://www.datacarpentry.org/R-spatial-raster-vector-lesson/01-raster-structure/) and when I clicked the NEON AOP LiDAR sensor (URL: http://www.neonscience.org/science-design/collection-methods/airborne-remote-sensing) the page was not found.

lwasser commented 6 years ago

it looks like this is the new link http://www.neonscience.org/data-collection/airborne-remote-sensing

Does that look right to you @PunamA ??

Are you comfortable with creating a pull request to make this update to the .Rmd file? and if you are you can submit that and add the PR id to this issue! i'm labeling this as a bug in the lessons !

PunamA commented 6 years ago

Hi Leah, I tried to create a pull request, but i'm not sure if I did it correctly. I also forked the 01-raster-structure.Rmd and updated it but I believe it is only in my fork and not sure how to merge it with the data-carpentries pages.

Sorry, i'm new to the GitHub but very much want to learn it properly.

jsta commented 6 years ago

Hi @PunamA,

It's great you want to learn Github! One difficulty I see with your pull request is that it needs to be made against the "master" branch not the "gh-pages" branch (see #127). My recommendation for small fixes like bad links is to edit the file in the browser by clicking the pencil icon rather than pulling your own local copy:

image

PunamA commented 6 years ago

Hi @jsta ,

oh few, I was just writing back because I thought I made a mistake by closing it. let me know if I need to try change anything. this was a great learning experience for me :)

jsta commented 6 years ago

Good to hear. Thanks for the PR!

lwasser commented 6 years ago

hey @PunamA would you like to learn how to work on these things on a fork rather than a direct edit to this repo? I think your workflow is great! BUT forking is much better as it will ultimately allow you to work locally as well if you want to more easily. it's up to you!! but let us know if that is of interest!!

THANK YOU for this update to the lessons.

If you did fork the repo... you can make a pull request from that repo to suggest those changes here. that is the preferred working approach :)

lwasser commented 6 years ago

i'm leaving this closed but if you'd like to try this i could walk you through it in an issue!! a new issue and we could make one small change to the lessons

PunamA commented 6 years ago

Hi @lwasser , yes I would definitely love to do that. I think I created a fork on the repository:

github