Closed kristi-sara closed 1 year ago
Thank you for your pull request :smiley:
:robot: This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.
If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
:mag: Inspect the changes: https://github.com/datacarpentry/r-raster-vector-geospatial/compare/md-outputs..md-outputs-PR-421
The following changes were observed in the rendered markdown documents:
09-vector-when-data-dont-line-up-crs.md | 17 ++++++++++++-----
...line-up-crs-rendered-layer-point-on-states-1.png | Bin 32692 -> 31678 bytes
...ne-up-crs-rendered-us-boundaries-thickness-1.png | Bin 14961 -> 13399 bytes
md5sum.txt | 2 +-
4 files changed, 13 insertions(+), 6 deletions(-)
:stopwatch: Updated at 2023-08-02 20:09:11 +0000
Just popping in here to highlight something about The Workbench for @datacarpentry/r-raster-vector-geospatial-maintainers. One of the fun things about the pull request rendering of markdown documents is that we can actually see that the changes had the desired effect: https://github.com/datacarpentry/r-raster-vector-geospatial/compare/md-outputs..md-outputs-PR-421#diff-94ec36416d7ba361d5aef79f0418c5d589d2f3ae33dfc3cb1c767c370306bf42
Thank you for your contribution @kristi-sara. This definitely resolves an issue between our lesson text and output.
When combining the state and country boundary, the lesson states the county boundary is supposed to be a slightly bolded outline, however, the state boundary shapefile is masking the country boundary so the bold outline does not show up. This would work if the country boundary layer had an alpha and was layered over the state boundary layer.
After making country border darker, adding alpha, and increasing size slightly:
(Here's what it looks like in our fork:https://ucsb-dreamlab.github.io/r-raster-vector-geospatial/09-vector-when-data-dont-line-up-crs.html)