search

datacarpentry / r-raster-vector-geospatial

Introduction to Geospatial Raster and Vector Data with R
https://datacarpentry.org/r-raster-vector-geospatial
Other
113 stars 110 forks source link

Update 07-vector-shapefile-attributes-in-r.Rmd #449

Open rfbrown opened 5 months ago

rfbrown commented 5 months ago

Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.

Update element_rect(size = 1) to element_rect(line_width = 1) to address warning: The size argument of element_rect() is deprecated as of ggplot2 3.4.0. ℹ Please use the linewidth argument instead.

github-actions[bot] commented 5 months ago

:ok: Pre-flight checks passed :smiley:

This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits.

It should be safe to Approve and Run the workflows that need maintainer approval.

rfbrown commented 5 months ago

We note that the warning also shows up in the lesson and can be used as an example (which we did on the fly)- but if used as an example, the lesson should contain descriptive text about the warning.

Note that there are a few other places in the lesson where this issue shows up, so the fix should be consistent. We suggest changing all mentions of element_rect(size = ) to element_rect(linewidth = ).