search

datacarpentry / r-socialsci

R for Social Scientists
https://datacarpentry.org/r-socialsci/
Other
117 stars 207 forks source link

Update 02-starting-with-data.Rmd #499

Closed marionwalton closed 10 months ago

marionwalton commented 10 months ago

Fixed typos and improved clarity in section about Renaming Factors

If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number.

Closes #495

Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.

Improved clarity by fixing typos in discussion of Renaming Factors ( The paragraph about respondents with missing data isn't clear. ) The lack of clarity is mainly caused by two typos (sentences are missing parts of verbs - "is" and "be") The meaning is also somewhat muddied because we usually use "who" to refer to people (not "which")

If any relevant discussions have taken place elsewhere, please provide links to these.

https://github.com/datacarpentry/r-socialsci/issues/495

For more guidance on how to contribute changes to a Carpentries project, please review [the Contributing Guide](CONTRIBUTING.md) and [Code of Conduct](https://docs.carpentries.org/topic_folders/policies/code-of-conduct.html). Please keep in mind that lesson Maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at team@carpentries.org.
github-actions[bot] commented 10 months ago

Thank you!

Thank you for your pull request :smiley:

:robot: This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

Rendered Changes

:mag: Inspect the changes: https://github.com/datacarpentry/r-socialsci/compare/md-outputs..md-outputs-PR-499

The following changes were observed in the rendered markdown documents:

 02-starting-with-data.md | 6 +++---
 md5sum.txt               | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)
What does this mean? If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

:stopwatch: Updated at 2023-12-13 13:51:10 +0000

juanfung commented 10 months ago

@marionwalton this looks great, thank you!