search

datacarpentry / spreadsheet-ecology-lesson

Data Organization in Spreadsheets for Ecologists
https://datacarpentry.org/spreadsheet-ecology-lesson
Other
37 stars 141 forks source link

Resolve conflicting advice in 01 and 02 re tracking changes to data #237

Closed amandawhitmire closed 5 years ago

amandawhitmire commented 6 years ago

These commits include the following changes:

  1. Align the language in 02-common-mistakes.md regarding use of tabs. Not only is 01 in conflict with 02 (as @hoytpr mentions), but two of the Key Points in 02 are in conflict with each other: "Avoid spreading data across multiple tabs (but do use a new tab to record data cleaning or manipulations)," and "Record metadata in a separate plain text file." I would modify the first Key Point and the narrative section regarding tabs in the text above. I would keep the section on "Inclusion of metadata in data table" as-is.

  2. Update Figure 1 in 01-format-data.md to show notes in a text file, not in a new tab of the working spreadsheet, and update narrative text in "Keeping track of your analyses" to align with that advice. Also update Key Point regarding tracking steps to mention using a text file.

I added a new screenshot figure to /fig - please double-check that this works after the merge. :-)

fix#209 fix#227

hoytpr commented 6 years ago

Hi @amandawhitmire, thank-you for this PR. It looks like you put a lot of good work into it, and so "it looks good to me". @tracykteal @cbahlai

hoytpr commented 5 years ago

Thanks @amandawhitmire!