search

datacarpentry / spreadsheet-ecology-lesson

Data Organization in Spreadsheets for Ecologists
https://datacarpentry.org/spreadsheet-ecology-lesson
Other
37 stars 141 forks source link

Step1 for exercise 1 for Conditional formatting #256

Closed kmadzima closed 5 years ago

kmadzima commented 5 years ago

There is an error in the Quality Control Episode of the Data Organisation in Spreadsheets for Ecologists https://datacarpentry.org/spreadsheet-ecology-lesson/04-quality-control/index.html

Description of the Error The current step 1 suggests that users must click FORMAT>Conditional Formating but the current versions of Microsoft Excel in Office 2016 or Office 365 no longer have the Format as a main menu option. There is also a a missing t in the spelling for Formatting.

Suggested Correction The corrected version should read as follows:

  1. In the main Excel menu bar, click Home tab > Conditional Formatting... Click the + to add a formatting rule.

This is a submission for Instructor checkout

hoytpr commented 5 years ago

Hi @kmadzima and thanks for your contribution. It's always great to get rid of typos (they seem to never end). Also you are correct; Format> Conditional Formatting is incorrect, even in Excel 2013 (which I'm still running). In 2013 you click the Home tab, then select "Conditional Formatting" under Styles, and the drop down menu takes you to "new Rule". Do you want to try a Pull Request to fix these issues? We (Maintainers) don't usually create and merge our own PRs. It would be great if you could try.

Thanks again and let me know what you are comfortable with attempting. Peter

kmadzima commented 5 years ago

Dear Peter

I have just submitted a pull request for the issue. I am also willing to continue making contributions.

Kind Regards

Kudakwashe Madzima

On Thu, Jan 31, 2019 at 5:58 PM Pete notifications@github.com wrote:

Hi @kmadzima https://github.com/kmadzima and thanks for your contribution. It's always great to get rid of typos (they seem to never end). Also you are correct; Format> Conditional Formatting is incorrect, even in Excel 2013 (which I'm still running). In 2013 you click the Home tab, then select "Conditional Formatting" under Styles, and the drop down menu takes you to "new Rule". Do you want to try a Pull Request to fix these issues? We (Maintainers) don't usually create and merge our own PRs. It would be great if you could try.

Thanks again and let me know what you are comfortable with attempting. Peter

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/datacarpentry/spreadsheet-ecology-lesson/issues/256#issuecomment-459397825, or mute the thread https://github.com/notifications/unsubscribe-auth/AjoBzZQTEqQc48gzdsK37UTQ2dclbgZXks5vIxKbgaJpZM4ack9V .

hoytpr commented 5 years ago

Hi @kmadzima it looks like you closed this issue almost as soon as you put in the pull request. When you do that, your Pull Request won't work. Do you want to reopen this? It looks good and I should be able to merge the PR as soon as you reopen it. Thanks very much for contributing! Peter

hoytpr commented 5 years ago

Thanks @kmadzima !