search

datacarpentry / spreadsheet-ecology-lesson

Data Organization in Spreadsheets for Ecologists
https://datacarpentry.org/spreadsheet-ecology-lesson
Other
37 stars 141 forks source link

Added a step to Conditional Formatting exercise. Removed color speci… #270

Closed mhayslett closed 5 years ago

mhayslett commented 5 years ago

…fication from the directions.

The exercise doesn't work if the column isn't highlighted, so added that as a first step. Also yellow-orange was not an option when I opened the color scale formatting, so I changed that to be color non-specific.

hoytpr commented 5 years ago

Hi @mhayslett and thanks for pointing this out. You'll need to fix the numbering (so there aren't two number "2."'s in the pull request. before we can merge this. Also, we can talk about adding a comment on conditional formatting, but let's get this functional typo fixed first. Sound good? Thanks again.

hoytpr commented 5 years ago

@mhayslett , just wanted to make sure you saw my message about the comment in your PR. Your input is an important part of the Carpentries community, and All you have to do is remove the comment for this PR to be merged!! Thanks so much for contributing, and let's get you the credit you deserve!

mhayslett commented 5 years ago

Apologies, Pete, I didn’t understand what you meant in your first message. I edited the PR—let me know if that worked.

Thanks,

Michele

From: Pete notifications@github.com Sent: Tuesday, June 18, 2019 9:26 AM To: datacarpentry/spreadsheet-ecology-lesson spreadsheet-ecology-lesson@noreply.github.com Cc: Hayslett, Michele Matz michele_hayslett@unc.edu; Mention mention@noreply.github.com Subject: Re: [datacarpentry/spreadsheet-ecology-lesson] Added a step to Conditional Formatting exercise. Removed color speci… (#270)

@mhaysletthttps://github.com/mhayslett , just wanted to make sure you saw my message about the comment in your PR. Your input is an important part of the Carpentries community, and All you have to do is remove the comment for this PR to be merged!! Thanks so much for contributing, and let's get you the credit you deserve!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/datacarpentry/spreadsheet-ecology-lesson/pull/270?email_source=notifications&email_token=AI46BXS5KFKR4FTO53VZWT3P3DO7BA5CNFSM4HYXPXWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX6TRTI#issuecomment-503134413, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AI46BXQFSOFMJJNZBKQHM7TP3DO7BANCNFSM4HYXPXWA.