search

datacarpentry / spreadsheet-ecology-lesson

Data Organization in Spreadsheets for Ecologists
https://datacarpentry.org/spreadsheet-ecology-lesson
Other
37 stars 141 forks source link

Possible typo in drop down list sample? #278

Closed maneesha closed 4 years ago

maneesha commented 4 years ago

The demonstration dropdown list here: image

includes the items:

It looks like the third item on the list is a typo.

hoytpr commented 4 years ago

Thanks @maneesha This is (to my understanding) an intentional misspelling. Please verify @tracykteal or @cbahlai

hoytpr commented 4 years ago

Maneesha, This appears to be an intentional mis-spelling. I'm going to close this issue, but thanks very much for pointing this out!

maneesha commented 4 years ago

Thanks. I'll defer to you all as lesson maintainers, but I don't think it makes sense to me. The drop down is presented in the context of data validation, which has the goal of ensuring that the person entering data does not make typos. If it is indeed an intentional typo used for teaching purposes, it should be identified as such in the lesson material.

hoytpr commented 4 years ago

Fair enough, please feel free to send in a PR!

By re-opening, maybe we can get some more discussion!

@maneesha I re-read my comments above and realized it had unclear intent. I'm happy to make this change, and appreciate your contribution and attention to the lesson. My opinion is that this spreadsheet has too many flaws for the timeframe of a workshop, and minimizing the number of flaws is a good idea! When you responded quickly and affirmed your opinion, it didn't take much convincing for me to re-open this, and sincerely encourage you to submit a PR. I could delete what I wrote, but would rather leave it to remind myself (and others) that running off to a meeting doesn't absolve me from writing a well-formed email response.

hoytpr commented 4 years ago

Also good to acknowledge that this issue, taken outside the context of the OpenRefine lesson, is simply a typo. @maneesha I've attached an image to replace the one in the lesson. If you could find the time to put this into a PR, I would appreciate it. drop_down_list

hoytpr commented 4 years ago

After teaching this today. The spelling error is not pertinent to the base lesson. New file named drop_down_list2.png was created to protect any other lesson dependencies.