search

datacarpentry / spreadsheet-ecology-lesson

Data Organization in Spreadsheets for Ecologists
https://datacarpentry.org/spreadsheet-ecology-lesson
Other
37 stars 141 forks source link

prevent jekyll-cache transfers #292

Closed hoytpr closed 4 years ago

hoytpr commented 4 years ago

This changes the _config.yml and the .gitignore files to prevent a jekyll-cache folder from being uploaded. This does not appear to affect the page rendering. @tracykteal @fmichonneau please review.

fmichonneau commented 4 years ago

Hi Pete, I opened #294 that brings all the latest improvements from the styles repository including adding .jekyll-cache to the .gitignore. I did this to avoid having to potentially deal with merge conflicts down the line.

Also note that the .jekyll-cache folder gets created by Jekyll 4 (that GitHub Pages doesn't support yet). So it's best to use the Make command make serve to preview the site locally if you can or at least bundle exec jekyll serve.

Please let me know if you have any questions! Thank you!

tracykteal commented 4 years ago

Thanks so much @fmichonneau. PR #294 looks good to me.

hoytpr commented 4 years ago

All your efforts are greatly appreciated! I would like to note that although jekyll serve works well on my newly updated machine, make serve or bundle exec jekyll serve do not work in a non-carpentry repo (like https://hoytpr.github.io/Windows-jekyll-install/). 

$ bundle exec jekyll serve
Could not locate Gemfile or .bundle/ directory
$ make serve
bash: make: command not found

So there is more for me to learn. ☺