search

datacarpentry / spreadsheet-ecology-lesson

Data Organization in Spreadsheets for Ecologists
https://datacarpentry.org/spreadsheet-ecology-lesson
Other
37 stars 141 forks source link

null data HTML conversion #320

Closed hoytpr closed 1 year ago

hoytpr commented 1 year ago

This works on my desktop for converting the Null data table to HTML.

tobyhodges commented 1 year ago

Thanks @hoytpr it looks good on my local build too.

Reading through the related issue https://github.com/LibraryCarpentry/lc-spreadsheets/issues/124 there are some good suggestions for how the table could be made clearer and I think this is a good opportunity to make some of those changes. Specifically:

  1. the literal values could be distinguished from the descriptive values in the first column. I.e. "Blank" is a description of the value that could be used and it might be helpful to adjust the table somehow to indicate that this is different from e.g. "None", which is a suggestion to use the literal value "None" to indicate missing data. My favourite option for this: format the literal values as "code" (0, -,+,., None). Would you be willing to update the pull request to format the values in this way?
  2. @SandiCal suggested an improvement to the explanation in the paragraph that precedes the table, and it sounded like @morskyjezek was planning to work up a pull request based on that. Would one of you have time to open up a second pull request on this repository? We could then discuss, review, and merge both here before propagating the improvements to the other two lessons that include this content.