Do not cache multifacet values in memory - Githubissues

datacite / akita

DataCite Commons

https://commons.datacite.org

MIT License

6 stars 3 forks source link

Do not cache multifacet values in memory #281

Closed jrhoads closed 11 months ago

jrhoads commented 11 months ago

Purpose

Apollo was caching values for multifacets, this is not desirable. They should be treated much like regular facets.

Approach

Disables inMemoryCache for multiFacets in the ApolloClient config.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

Be humble in the language and feedback you give, ask don't tell.
Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
Offer suggestions on how to improve code e.g. simplification or expanding clarity.
Ensure you give reasons for the changes you are proposing.

cypress[bot] commented 11 months ago

Passing run #930 ↗︎

0

64

0

0

0

Details:

Merge f397125b7041d6084238cbcc634f5128e7ae43fa into 3136925ad16077cb906689e70954...
Project: akita	Commit: `bf8f451c1d ℹ️`
Status: Passed	Duration: 02:44 💡
Started: Sep 5, 2023 3:24 PM	Ended: Sep 5, 2023 3:27 PM

_{This comment has been generated by cypress-bot as a result of this
project's GitHub integration settings.}