Package upgrade fix - Githubissues

richardhallett commented 11 months ago

Purpose

This is to upgrade dependencies for Akita.

This came about due to build errors on production minified version see: https://github.com/datacite/datacite/issues/1933

Approach

Upgrades everything, but I did it in stages to narrow down any potential problems.

The bug comes about from upgrading react-vega specifically, however I believe it to be as a result of the webpack build process.

The fix seems to be just ensuring everything is upgrading, including upgrading NextJS to version 13 from 12, which then also updates the webpack build process. The upgrade was relativly simple requiring only marginal source code changes.

Open Questions and Pre-Merge TODOs

Learning

https://nextjs.org/docs/pages/building-your-application/upgrading/version-13

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

Be humble in the language and feedback you give, ask don't tell.
Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
Offer suggestions on how to improve code e.g. simplification or expanding clarity.
Ensure you give reasons for the changes you are proposing.

jrhoads commented 5 months ago

@richardhallett I think this has been superseded by https://github.com/datacite/akita/pull/321 and https://github.com/datacite/akita/pull/326

Can we close this?

richardhallett commented 5 months ago

Probably, in truth I forgot all about this PR.

datacite / akita

Package upgrade fix #289