Update footer links - Githubissues

KellyStathis commented 11 months ago

Purpose

Updates the site footer for https://commons.datacite.org/ to correspond with the new website structure.

Approach

Updated Footer.tsx to match the new footer links structure, per the list in DataCite - homepage inventory. This matches the list in links.json (from assets repository) but does not use this file.
Reordered social links and added the Mastodon link.

Open Questions and Pre-Merge TODOs

[ ] With a more recent version of fort awesome we can use faXTwitter (see https://www.npmjs.com/package/@fortawesome/free-brands-svg-icons?activeTab=code) instead of the svg. However, we are currently on 5.15.3 which does not include faXTwitter. If it is simpler to upgrade the version, that would be a cleaner solution than the svg.
[ ] There is an open todo in Footer.tsx to "Links from '../../../config/links.yml'. I haven't updated links.yml yet. Is this file used and if so should I update it?

Learning

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

Be humble in the language and feedback you give, ask don't tell.
Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
Offer suggestions on how to improve code e.g. simplification or expanding clarity.
Ensure you give reasons for the changes you are proposing.

cypress[bot] commented 11 months ago

Passing run #965 ↗︎

0

64

0

Details:

Merge 18312213e01eb6498c6f9e262650c617f3b868a6 into 48d0ec1ce928005c5531d3ab2c06...
Project: akita	Commit: `3fa531f3aa ℹ️`
Status: Passed	Duration: 02:38 💡
Started: Sep 29, 2023 1:23 AM	Ended: Sep 29, 2023 1:25 AM

Review all test suite changes for PR #293 ↗︎

KellyStathis commented 11 months ago

@jrhoads, Suzanne mentioned you might be a good person to ask about the open questions, since you worked on this recently

cypress[bot] commented 11 months ago

Passing run #941 ↗︎

0

64

0

Details:

update footer links
Project: akita	Commit: `d1217fd57f`
Status: Passed	Duration: 02:36 💡
Started: Sep 20, 2023 7:06 PM	Ended: Sep 20, 2023 7:09 PM

_{This comment has been generated by cypress-bot as a result of this
project's GitHub integration settings.}

svogt0511 commented 11 months ago

@KellyStathis, @jrhoads - just noticed. I was running Akita locally to check the Fabrica footer against the Akita footer. I noticed There are some errors and warnings in the browser dev console The one, belowm is from the log. I thought I would mention it because it is coming from react-bootstrap and it might have something to do with the font - although everything in the footer seems to look and behave fine: