Closed KellyStathis closed 11 months ago
![]() |
![]() |
![]() |
![]() |
![]() |
Details:
Merge 18312213e01eb6498c6f9e262650c617f3b868a6 into 48d0ec1ce928005c5531d3ab2c06... | |||
Project: akita | Commit: 3fa531f3aa ℹ️ |
||
Status: Passed | Duration: 02:38 💡 | ||
Started: Sep 29, 2023 1:23 AM | Ended: Sep 29, 2023 1:25 AM |
@jrhoads, Suzanne mentioned you might be a good person to ask about the open questions, since you worked on this recently
![]() |
![]() |
![]() |
![]() |
![]() |
Details:
update footer links | |||
Project: akita | Commit: d1217fd57f |
||
Status: Passed | Duration: 02:36 💡 | ||
Started: Sep 20, 2023 7:06 PM | Ended: Sep 20, 2023 7:09 PM |
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
@KellyStathis, @jrhoads - just noticed. I was running Akita locally to check the Fabrica footer against the Akita footer. I noticed There are some errors and warnings in the browser dev console The one, belowm is from the log. I thought I would mention it because it is coming from react-bootstrap and it might have something to do with the font - although everything in the footer seems to look and behave fine:
Fixed the warnings in the browser dev console:
that enclosed the examples in all of the tab index.tsx files to
(see the screengrab)I am closing this pull request and deploying it to production.
Purpose
Updates the site footer for https://commons.datacite.org/ to correspond with the new website structure.
Approach
Open Questions and Pre-Merge TODOs
Learning
Types of changes
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
Reviewer, please remember our guidelines: