Closed wendelfabianchinsamy closed 10 months ago
![]() |
![]() |
![]() |
![]() |
![]() |
Details:
Merge 3b345cc839ec41f05dca3c35034269ea1aba5028 into 9c9349377b7ed6207a2ac16e6db7... | |||
Project: akita | Commit: 36dc3120af ℹ️ |
||
Status: Passed | Duration: 02:46 💡 | ||
Started: Sep 27, 2023 1:26 PM | Ended: Sep 27, 2023 1:29 PM |
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
Nice fix! Noting that it might be good to handle search query string normalization on the lupo/GraphQL API side in addition to akita/Commons. I think this fix will work well for queries conducted in akita/Commons but won't address GraphQL queries conducted elsewhere.
Nice fix! Noting that it might be good to handle search query string normalization on the lupo/GraphQL API side in addition to akita/Commons. I think this fix will work well for queries conducted in akita/Commons but won't address GraphQL queries conducted elsewhere.
@codycooperross great point. @ashwinisukale and @kaysiz, would you agree then that it would be best to implement this fix on the lupo/Graphql end instead of here. If so we could probably nuke this pr.
@wendelfabianchinsamy I agree, lets nuke this PR in favor of the one on lupo
Purpose
closes: https://github.com/datacite/datacite/issues/1786
Approach
Open Questions and Pre-Merge TODOs
Learning
Types of changes
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
Reviewer, please remember our guidelines: