Adds Vega color assignments for Schema 4.5 resourceTypeGeneral additions - Githubissues

datacite / akita

DataCite Commons

https://commons.datacite.org

MIT License

6 stars 3 forks source link

Adds Vega color assignments for Schema 4.5 resourceTypeGeneral additions #314

Closed codycooperross closed 8 months ago

codycooperross commented 8 months ago

Purpose

Adds Vega color assignments for Schema 4.5 resourceTypeGeneral additions.

closes: #311

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

Be humble in the language and feedback you give, ask don't tell.
Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
Offer suggestions on how to improve code e.g. simplification or expanding clarity.
Ensure you give reasons for the changes you are proposing.

cypress[bot] commented 8 months ago

Passing run #996 ↗︎

0

64

0

0

0

Details:

Merge 6ebd5dba27f45b6d1db576954e0721486fd6aea9 into 1d5c6a715fd31c9843f08b87278f...
Project: akita	Commit: `32c65f24a1 ℹ️`
Status: Passed	Duration: 02:16 💡
Started: Dec 15, 2023 3:17 PM	Ended: Dec 15, 2023 3:19 PM

Review all test suite changes for PR #314 ↗︎