datacite / akita

DataCite Commons
https://commons.datacite.org
MIT License
6 stars 3 forks source link

Added support for new publisher object in graphql #315

Closed bklaing2 closed 6 months ago

bklaing2 commented 7 months ago

Purpose

Adds support for https://github.com/datacite/lupo/pull/1075

closes: Add github issue that originated this PR

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

Reviewer, please remember our guidelines:

cypress[bot] commented 7 months ago

2 failed and 1 flaky tests on run #1069 ↗︎

2 62 0 0 Flakiness 1

Details:

Merge f237c02dff798450d273f7e03396c26cf6f67bc1 into fe28af179e3ba5ff100ba54fc8db...
Project: akita Commit: 45b06f3af3 ℹ️
Status: Failed Duration: 02:52 💡
Started: Feb 27, 2024 10:00 PM Ended: Feb 27, 2024 10:02 PM
Failed  search.test.ts • 1 failed test • Tests View Output
Test Artifacts
... > search with enter Test Replay Screenshots
Failed  personContainer.test.ts • 1 failed test • Tests View Output
Test Artifacts
PersonContainer > links Test Replay Screenshots
Flakiness  cypress/e2e/statistics.test.ts • 1 flaky test • Tests View Output
Test Artifacts
Overview > header Test Replay Screenshots

Review all test suite changes for PR #315 ↗︎

jrhoads commented 6 months ago

Is this ready for deployment? Is the lupo side of things ready for it?

codycooperross commented 6 months ago

Is this ready for deployment? Is the lupo side of things ready for it?

Not ready for deployment yet. The lupo side of things are prepped in a different PR but haven't been merged: https://github.com/datacite/lupo/pull/1075