datacite / akita

DataCite Commons
https://commons.datacite.org
MIT License
6 stars 3 forks source link

Separate loading and error handling for DOI, Organization, and Person pages #317

Closed bklaing2 closed 7 months ago

bklaing2 commented 7 months ago

Purpose

Currently, all of the data is fetched in one big pass. These changes split up the query into two separate queries that can run in parallel, allowing it to quickly fetch and show the metadata for the DOI, organization, or person, while loading the related content.

Additionally, if an error occurs during the related content loading, the metadata section will still be shown, and an error message will only be shown in the related content section.

Approach

For each page, the query has been split up into two queries, metadata and related content, that run in parallel. They each have their own rendering and handling logic

Open Questions and Pre-Merge TODOs

Learning

Types of changes

Reviewer, please remember our guidelines:

cypress[bot] commented 7 months ago

Passing run #1003 ↗︎

0 64 0 0 Flakiness 0

Details:

Merge 0c1e88a733cb76feb6bed3995c4fddb23bd724c1 into 1966678c53c19270849b1aa7227c...
Project: akita Commit: 723fb7a9be ℹ️
Status: Passed Duration: 02:13 💡
Started: Jan 22, 2024 1:06 PM Ended: Jan 22, 2024 1:08 PM

Review all test suite changes for PR #317 ↗︎