Moved isBot check into middleware - Githubissues

datacite / akita

DataCite Commons

https://commons.datacite.org

MIT License

6 stars 3 forks source link

Moved isBot check into middleware #318

Closed bklaing2 closed 7 months ago

bklaing2 commented 7 months ago

Purpose

Moved the isBot check logic into middleware, so it can now be used from any page. Additionally, added a custom isBot check to include the GoogleOther bot

Google bot reference

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

Be humble in the language and feedback you give, ask don't tell.
Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
Offer suggestions on how to improve code e.g. simplification or expanding clarity.
Ensure you give reasons for the changes you are proposing.

cypress[bot] commented 7 months ago

Passing run #1006 ↗︎

0

64

0

0

0

Details:

Merge d1aba24bf0ac7ff8935f1260bc1a9830c06424e3 into 71c4cf346e5d021eca209dbdfd32...
Project: akita	Commit: `9381c6e798 ℹ️`
Status: Passed	Duration: 02:14 💡
Started: Jan 22, 2024 4:07 PM	Ended: Jan 22, 2024 4:09 PM

Review all test suite changes for PR #318 ↗︎