Upgrade NextJS

[bklaing2]

Purpose

Upgraded NextJS from version 12 to 13

As a side effect, react, react-dom, (and their types), and cypress needed to be upgraded. This caused the react-bootstrap overlay trigger to throw an error, as it wasn't compatible with the updated version of react. I implemented this fix.

Open Questions and Pre-Merge TODOs

• [x] Merge https://github.com/datacite/akita/pull/326 into this branch first
• [x] NextJS <Link> components in version 13 no longer allow <a> tags to be children. I've added the legacyBehavior to each link to ignore this for now.
  • Fixed in https://github.com/datacite/akita/pull/326
• [x] I had to add useEffect to the doi, org, person, and repo search pages due to hydration issues. More research is needed to find a proper solution to this issue.
  • This problem is resolved when migrating the pages to use the app router
  • https://nextjs.org/docs/messages/react-hydration-error#possible-ways-to-fix-it

Other things to note

• When running with NODE_ENV=test, there was an error. The only place that NODE_ENV=test was set was in the Cypress tests Github action. I replaced NODE_ENV with CYPRESS_NODE_ENV, and the error went away.
  • As far as I can tell, our Cypress test don't care what the NODE_ENV is anyways
• next-usequerystate is being renamed to nuqs

Learning

Types of changes

• [ ] Bug fix (non-breaking change which fixes an issue)

• [ ] New feature (non-breaking change which adds functionality)

• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

• Be humble in the language and feedback you give, ask don't tell.
• Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
• Offer suggestions on how to improve code e.g. simplification or expanding clarity.
• Ensure you give reasons for the changes you are proposing.

[cypress[bot]]

1 flaky test on run #1032 ↗︎

0

64

0

0

1

Details:

Merge 2a9226ea218d3ff2da371766d5fb52f1d59f0843 into 60a5a796948ff9aa104966765e72...
Project: akita	Commit: 8c7bbba726 ℹ️
Status: Passed	Duration: 02:26 💡
Started: Jan 31, 2024 3:48 PM	Ended: Jan 31, 2024 3:50 PM

  cypress/e2e/personContainer.test.ts • 1 flaky test • Tests

View Output

Test		Artifacts
PersonContainer > production chart		Test Replay Screenshots

Review all test suite changes for PR #321 ↗︎