datacite / akita

DataCite Commons
https://commons.datacite.org
MIT License
5 stars 3 forks source link

Set up app layout #340

Closed bklaing2 closed 5 months ago

bklaing2 commented 5 months ago

Purpose

Set up the layout for the app router

closes: #332

Approach

Migrated the Layout component being used across the pages router to work with the app router. It now lives in the src/app/layout.tsx file, and any sibling or child page.tsx files are passed to it as children.

Open Questions and Pre-Merge TODOs

Learning

Referenced the NextJS docs to understand the app router.

Types of changes

Reviewer, please remember our guidelines:

cypress[bot] commented 5 months ago

1 flaky test on run #1040 ↗︎

0 64 0 0 Flakiness 1

Details:

Merge 30b3d371f1bd208ce36d3c9c3f57a36bbe7a8968 into bfdbdd05ef81edbeb9b2e22b4e21...
Project: akita Commit: 03fff29392 ℹ️
Status: Passed Duration: 02:39 💡
Started: Feb 1, 2024 3:42 PM Ended: Feb 1, 2024 3:44 PM
Flakiness  cypress/e2e/personContainer.test.ts • 1 flaky test • Tests View Output
Test Artifacts
PersonContainer > tags Test Replay Screenshots

Review all test suite changes for PR #340 ↗︎