datacite / akita

DataCite Commons
https://commons.datacite.org
MIT License
5 stars 3 forks source link

Fix Sankey chart bug #344

Closed bklaing2 closed 4 months ago

bklaing2 commented 4 months ago

Purpose

Sankey charts may have wrong bar heights

image

This change fixes that

image

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

Reviewer, please remember our guidelines:

cypress[bot] commented 4 months ago

3 flaky tests on run #1062 ↗︎

0 64 0 0 Flakiness 3

Details:

Merge f6c7dbf7ce1065db0fb5cd7b82ce9c54e0bffc0f into aaab84df7fbc05473ef3de97b7c7...
Project: akita Commit: 9e0ef28cae ℹ️
Status: Passed Duration: 03:03 💡
Started: Feb 27, 2024 4:17 PM Ended: Feb 27, 2024 4:20 PM
Flakiness  search.test.ts • 1 flaky test • Tests View Output
Test Artifacts
... > search with enter Test Replay Screenshots
Flakiness  personContainer.test.ts • 2 flaky tests • Tests View Output
Test Artifacts
PersonContainer > links Test Replay Screenshots
PersonContainer > facets Test Replay Screenshots

Review all test suite changes for PR #344 ↗︎