Logged in bug

[bklaing2]

Purpose

DOIs that included the Claim button would throw an error

closes: Add github issue that originated this PR

Approach

The Claim component had hooks after early returns. This moved the returns to after the hooks. Also fixed session bug for app router

Open Questions and Pre-Merge TODOs

Learning

Types of changes

• [ ] Bug fix (non-breaking change which fixes an issue)

• [ ] New feature (non-breaking change which adds functionality)

• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

• Be humble in the language and feedback you give, ask don't tell.
• Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
• Offer suggestions on how to improve code e.g. simplification or expanding clarity.
• Ensure you give reasons for the changes you are proposing.

[cypress[bot]]

5 flaky tests on run #1155 ↗︎

0

56

0

0

5

Details:

Merge 8ccc008fd8a9a7d8b9025aaa8939be2824fda9a2 into 625d6fe919c9c23c450faa6f28eb...
Project: akita	Commit: 3336d373aa ℹ️
Status: Passed	Duration: 02:52 💡
Started: Apr 17, 2024 9:20 AM	Ended: Apr 17, 2024 9:23 AM

  search.test.ts • 1 flaky test • Tests

View Output

Test		Artifacts
... > search with submit		Test Replay Screenshots

  statistics.test.ts • 1 flaky test • Tests

View Output

Test		Artifacts
Overview > header		Test Replay Screenshots

  personContainer.test.ts • 1 flaky test • Tests

View Output

Test		Artifacts
PersonContainer > identifiers		Test Replay Screenshots

  OrganizationContainerMissingGridID.test.ts • 2 flaky tests • Tests

View Output

Test		Artifacts
OrganizationContainer Display GridID if it exists > visit site with gridID, id element should exist		Test Replay Screenshots
OrganizationContainer Display GridID if it exists > visit site without gridID, id element not should exist		Test Replay Screenshots

Review all test suite changes for PR #354 ↗︎

[cypress[bot]]

2 flaky tests on run #1162 ↗︎

0

56

0

0

2

Details:

Logged in claim bug (#354)
Project: akita	Commit: 1d82746160
Status: Passed	Duration: 02:11 💡
Started: Apr 17, 2024 1:53 PM	Ended: Apr 17, 2024 1:55 PM

  personContainer.test.ts • 1 flaky test • Tests

View Output

Test		Artifacts
PersonContainer > facets		Test Replay Screenshots

  statistics.test.ts • 1 flaky test • Tests

View Output

Test		Artifacts
Overview > header		Test Replay Screenshots

Review all test suite changes for PR #354 ↗︎