Fix for license image stretching - Githubissues

datacite / akita

DataCite Commons

https://commons.datacite.org

MIT License

6 stars 3 forks source link

Fix for license image stretching #384

Closed codycooperross closed 3 weeks ago

codycooperross commented 3 weeks ago

Purpose

closes: datacite/datacite#2192

Approach

Use \<img> tag instead of NextJS \<Image>, which has requirements around including height and width in some circumstances.

Open Questions and Pre-Merge TODOs

Learning

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

Be humble in the language and feedback you give, ask don't tell.
Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
Offer suggestions on how to improve code e.g. simplification or expanding clarity.
Ensure you give reasons for the changes you are proposing.

cypress[bot] commented 3 weeks ago

Test summary

52 • 0 • 3 • 0 • 0

Run details


Project	akita
Status	Passed
Commit	7e69544346 ℹ️
Started	Aug 22, 2024 4:51 PM
Ended	Aug 22, 2024 4:54 PM
Duration	03:18 💡
OS	Linux Ubuntu -
Browser	Electron 114

View run in Cypress Cloud ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud