Researched different ways to handle parsing dates with fractional times according to the schema. Found a class which looked promising, but ended up not being supported for the version ruby we're using. After a bit more research I settled on using the Time.iso8601 method.
Types of changes
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
Be humble in the language and feedback you give, ask don't tell.
Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
Offer suggestions on how to improve code e.g. simplification or expanding clarity.
Ensure you give reasons for the changes you are proposing.
Purpose
Fixed issue where dates with fractional times wouldn't be returned from API
closes: https://github.com/datacite/datacite/issues/1361
Approach
Added Time.iso8601 to handle fractional times
Open Questions and Pre-Merge TODOs
Learning
Researched different ways to handle parsing dates with fractional times according to the schema. Found a class which looked promising, but ended up not being supported for the version ruby we're using. After a bit more research I settled on using the Time.iso8601 method.
Types of changes
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
Reviewer, please remember our guidelines: