Issues-1920 Keep newlines in the descriptions and convert the ascii co…

[ashwinisukale]

Purpose

While reading the XML file, new lines in the descriptions were removed due to the squish method

Root case:

We are using the https://github.com/datacite/bolognese/blob/010a854e642fefdcdf17d04dffa2b4de8721808c/lib/bolognese/utils.rb#L1060 squish method to remove new lines, extra internal spaces and any ASCII or unicodes form the string. eg. " foo bar \n \t \u2003Hello\u2009 boo".squish # => "foo bar Hello boo"

closes: https://github.com/datacite/datacite/issues/1920

Approach

Removed the squish method as we want to keep the spaces or new lines as it is in the description. Also I tried to test this change through test case with different types of special character, unicodes inside the string.

Open Questions and Pre-Merge TODOs

Learning

Types of changes

• [x] Bug fix (non-breaking change which fixes an issue)

• [ ] New feature (non-breaking change which adds functionality)

• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

• Be humble in the language and feedback you give, ask don't tell.
• Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
• Offer suggestions on how to improve code e.g. simplification or expanding clarity.
• Ensure you give reasons for the changes you are proposing.

[ashwinisukale]

Thanks @digitaldogsbody for the review, actually there is some discussion going on whether we need to keep new lines for all the tag in the XML or just for the description. Kelly is on leave, once she is back I will discuss with her, hence I have not modified other failing test cases as there is no clarity whether we need this change everywhere or not.