Closed codycooperross closed 11 months ago
FYI, I tested this branch of bolognese in the current main branch of lupo (prior to the 4.5 feature branch merge). All rspec tests passed, so bolognese should still be deployable in lupo if this branch is merged without any changes to lupo.
Purpose
Implements the new Schema 4.5 features and XSD, in particular the expansion of the
publisher
property to allow for additional attributes.closes: datacite/lupo#1004 #165
Approach
Modifies readers and writers to support both
publisher
as a hash with new attributes (publisherIdentifier
,publisherIdentifierScheme
, etc.) andpublisher
as a string. Adds tests for reading and writing these attributes.This PR also fixes an issue described in #165 that resulted in errors when validating the new
datacite-example-full-v4.5.xml
example, which contains a geoLocationPolygon property.Open Questions and Pre-Merge TODOs
publisher
properties beyond DataCite XML. Mapping from and to other schemas will be part of future work.crossref_writer.rb
is currently unmodified. Based on this test, it seems like writing Crossref metadata is expected to produce anil
value: https://github.com/datacite/bolognese/blob/7b3e8cd408cd141903765fb4904d33c5bba5ac42/spec/writers/crossref_writer_spec.rb#L15-L21 It appears that Crossref writing functionality is not supported yet. There is a several years old PR that proposed to add this functionality, but it was never merged: https://github.com/datacite/bolognese/pull/126/filesLearning
Types of changes
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
Reviewer, please remember our guidelines: