datacite / bolognese

Ruby gem and command-line utility for conversion of DOI metadata
MIT License
40 stars 14 forks source link

Support for Schema 4.5 #166

Closed codycooperross closed 11 months ago

codycooperross commented 1 year ago

Purpose

Implements the new Schema 4.5 features and XSD, in particular the expansion of the publisher property to allow for additional attributes.

closes: datacite/lupo#1004 #165

Approach

Modifies readers and writers to support both publisher as a hash with new attributes (publisherIdentifier, publisherIdentifierScheme, etc.) and publisher as a string. Adds tests for reading and writing these attributes.

This PR also fixes an issue described in #165 that resulted in errors when validating the new datacite-example-full-v4.5.xml example, which contains a geoLocationPolygon property.

Open Questions and Pre-Merge TODOs

Learning

Types of changes

Reviewer, please remember our guidelines:

codycooperross commented 1 year ago

FYI, I tested this branch of bolognese in the current main branch of lupo (prior to the 4.5 feature branch merge). All rspec tests passed, so bolognese should still be deployable in lupo if this branch is merged without any changes to lupo.