datacite / bolognese

Ruby gem and command-line utility for conversion of DOI metadata
MIT License
40 stars 14 forks source link

Citations may render the `container_title` as a hash in citations for DOIs with citeproc type `article-journal` #182

Closed codycooperross closed 9 months ago

codycooperross commented 9 months ago

Describe the bug

Citations may render the container_title as a hash in citations for DOIs with citeproc type article-journal; for example, as the following:

Feldman, H. L. (1995). Science and Uncertainty in Mass Exposure Litigation. {"Name"=>"Texas Law Review"}. https://doi.org/10.60843/5EGY-VC42

Expected Behaviour

Current Behaviour

Steps to Reproduce

See the citation rendering in the Fabrica page for DOI 10.60843/5EGY-VC42 or request the citation via API; for example, via https://api.datacite.org/dois/10.60843/5egy-vc42?style=apa with an Accept header text/x-bibliography

Context (Environment)

Primarily impacts Fabrica and content negotiation requests to lupo/the REST API.

Screenshots

Further details

Proposal

Hypothesis

The publisher attribute here is being returned as a complete hash rather than the expected publisher["name"]: https://github.com/datacite/bolognese/blob/b472e464494a4ec8b430de653ffda204eb3d7185/lib/bolognese/metadata_utils.rb#L99 This hash is rendered as part of the citation (container_title) under certain conditions.

Possible Implementation

Front logo Front conversations